Optional fields default to none #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to the prior work of @adriangb: 1Password#25
|
To the repo maintainers: this can be closed, this is only an improvement that will be included as part of #169 |
|
@amandayu1 It does look like #169 will include these changes. Do you object to me closing this PR as @hculea suggested? |
|
@savannidgerinel - for more context around this - this is not an open-source contribution, as Amanda was an intern with the Programmatic Interfaces team in the summer term. This was part of the team's sprint, and this work was eventually included in the other PR that I referenced. Also, since her internship ended, I believe Amanda no longer has access on the fork that contains this PR's source branch (which is under my namespace), so I think this should be safe to close 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.